CircleCI Ideas

Show overall "All checks have passed" status in github even on builds with incomplete "type: approval" job

I added a manual approval "trigger_rollback" job recently to my Circle 2.0 workflow and did not like the UI integration with github. On builds where I did not trigger this optional "trigger_rollback" job, the overall Github status was "Some checks haven't completed yet." (See screenshot.)

 

I talked to CircleCI support and they told me to deselect the status check for a "type: approval" job as described in this github article: https://circleci.com/docs/2.0/workflows-waiting-status/, which I had already done.

 

I still need the "trigger_rollback" job and corresponding status check. The "trigger_rollback" status check is type:approval, so I want it to be pending but I don't want the overall PR status to be pending -- instead I want the overall PR status to be green and say "All checks have passed."

  • Avatar32.5fb70cce7410889e661286fd7f1897de Guest
  • Jun 4 2018
  • Taking votes
  • Attach files
  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    8 Jun 02:05pm

    +1, renders impossible optional jobs :(

  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    26 Mar 04:26pm

    Is there any capability around this? This is really valuable for us as well, otherwise all of our successful builds look yellow instead of green.

  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    14 Jan 05:03pm

    +1 Having the same issue in our workflow

  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    30 Dec, 2019 07:02pm

    Any chance to have an update on this?

     

    This seems like an easy fix, proposals in merged ideas make sense.

    In my mind, something like this would be ideal:

     

    report: {true,false,always-success}

     

    The lack of such a feature makes it super painful to use approval jobs today w/ GitHub - using them implies losing useful UX there.

  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    16 Oct, 2019 04:24pm

    Not having this feature means we cannot consider CircleCI.

  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    21 May, 2019 11:26am

    +1. We need this feature in our Github integration.

  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    27 Nov, 2018 12:55pm

    Same issue here. We have an optinal approval step in case we want to manually deploy a branch to an environment. That doesn't mean that the tests are not passing. It's pretty annoying.

  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    17 Oct, 2018 07:43pm

    I'd love to have this feature. We want the approval as part of our work-in-process pipeline, without making every status check on the Pull Requests page in git show everything as pending.