CircleCI Ideas

branch filtering should also consider the base branch in pull requests (not just the current/head branch)

Our test jobs are filtered to a small set of protected branches like "master". Our common workflow is to submit pull requests into these branches from feature branches like "coolFeature"

However, tests do not begin running because the head branch "coolFeature" is not in the list of filtered branches. GitHub says "Waiting for status to be reported" forever. 

 

Suggestion: please also consider the base branch like "master" when filtering branches. Travis does this already.

 

I've created simple examples of this bug below

 

I also implemented a workaround in the tiny repository below, but I hope CircleCI fixes this soon

Workaround: https://github.com/sdolenc/circleCi_prsBranchFilter

  • Avatar32.5fb70cce7410889e661286fd7f1897de Guest
  • Mar 8 2018
  • Taking votes
  • Attach files